asgoel/fix inline instances #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ModelAdmin pages depend on the object itself existing and some properties of the object in order to display inlines. We should make sure we pass in the proper object when fetching inline instances in order to determine which action to use.
|
@escaped let me know if this makes sense |
|
@escaped just following up on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed a bug (I think) where the handle action function does not pass through the parent object into the
get_inline_instancesfunction. Sometimes, a ModelAdmin will display or not display an inline(s) based on some property of the object itself. So, this function was error'ing out with a unboundmodel_admininstance sinceget_inline_instanceswas coming up with an empty list.Fixes #(issue)
Checklist
CHANGELOG.mdCONTRIBUTORS.md