Skip to content

Fix slugify and cleanDiacritics for œ and æ #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix slugify and cleanDiacritics for œ and æ #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aad621d
Add test for slugify and cleanDiacritics of œ and æ
jazzzz Sep 13, 2017
9033c9d
Fix slugify and cleanDiacritics for œ and æ
jazzzz Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cleanDiacritics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

var makeString = require('./helper/makeString');

var from = 'ąàáäâãåæăćčĉęèéëêĝĥìíïîĵłľńňòóöőôõðøśșşšŝťțţŭùúüűûñÿýçżźž',
to = 'aaaaaaaaaccceeeeeghiiiijllnnoooooooossssstttuuuuuunyyczzz';
var from = 'ąàáäâãåăćčĉęèéëêĝĥìíïîĵłľńňòóöőôõðøśșşšŝťțţŭùúüűûñÿýçżźž',
to = 'aaaaaaaaccceeeeeghiiiijllnnoooooooossssstttuuuuuunyyczzz';

from += from.toUpperCase();
to += to.toUpperCase();
Expand All @@ -12,6 +12,10 @@ to = to.split('');
// for tokens requireing multitoken output
from += 'ß';
to.push('ss');
from += 'œ';
to.push('oe');
from += 'æ';
to.push('ae');


module.exports = function cleanDiacritics(str) {
Expand Down
8 changes: 5 additions & 3 deletions tests/cleanDiacritics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
var equal = require('assert').equal;
var cleanDiacritics = require('../cleanDiacritics');

var from = 'ąàáäâãåæăćčĉęèéëêĝĥìíïîĵłľńňòóöőôõðøśșşšŝťțţŭùúüűûñÿýçżźž',
to = 'aaaaaaaaaccceeeeeghiiiijllnnoooooooossssstttuuuuuunyyczzz';
var from = 'ąàáäâãåăćčĉęèéëêĝĥìíïîĵłľńňòóöőôõðøśșşšŝťțţŭùúüűûñÿýçżźž',
to = 'aaaaaaaaccceeeeeghiiiijllnnoooooooossssstttuuuuuunyyczzz';

test('#cleanDiacritics', function() {

Expand All @@ -20,5 +20,7 @@ test('#cleanDiacritics', function() {

equal(cleanDiacritics('ß'), 'ss');
equal(cleanDiacritics('Schuß'), 'Schuss');
});

equal(cleanDiacritics('œuf'), 'oeuf');
equal(cleanDiacritics('curriculum vitæ'), 'curriculum vitae');
});
1 change: 1 addition & 0 deletions tests/slugify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ var slugify = require('../slugify');
test('#slugify', function() {
equal(slugify('Jack & Jill like numbers 1,2,3 and 4 and silly characters ?%.$!/'), 'jack-jill-like-numbers-1-2-3-and-4-and-silly-characters');
equal(slugify('Un éléphant à l\'orée du bois'), 'un-elephant-a-l-oree-du-bois');
equal(slugify('Un œuf et un curriculum vitæ'), 'un-oeuf-et-un-curriculum-vitae');
equal(slugify('I know latin characters: á í ó ú ç ã õ ñ ü ă ș ț'), 'i-know-latin-characters-a-i-o-u-c-a-o-n-u-a-s-t');
equal(slugify('I am a word too, even though I am but a single letter: i!'), 'i-am-a-word-too-even-though-i-am-but-a-single-letter-i');
equal(slugify('Some asian 天地人 characters'), 'some-asian-characters');
Expand Down