Add VSIX gallery icon and ARM64 target for SSMS extension (#356)#357
Merged
Conversation
Adds a high-quality 128x128 gallery icon (downscaled from the app's EDD.icns DD mark) and an ARM64 InstallationTarget so ARM64 SSMS users can install the extension. Verified by building the VSIX with MSBuild and confirming the icon, <Icon> manifest entry, both amd64/arm64 targets, and the png content-type registration are all packaged. SSMS target version left at [17.0,) to keep supporting SSMS 18/19/20/21. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356 (the logo and ARM64 portions).
Changes
Resources/PerformanceStudioIcon.png), downscaled with LANCZOS from the 512×512 DD mark in the app'sEDD.icns. Wired it in via<Icon>in the manifest and<Content>/IncludeInVSIXin the csproj. This is the logo that shows on the SSMS Gallery listing.<InstallationTarget>with<ProductArchitecture>arm64</ProductArchitecture>so ARM64 SSMS users can install.Not changed
[17.0,)(covers SSMS 18/19/20/21/22). The issue suggested[22.0,), but we still have users on 18–20, so narrowing the floor would drop them.Test plan
Built the VSIX locally with the same command CI uses:
msbuild src/PlanViewer.Ssms/PlanViewer.Ssms.csproj -restore -t:Build -p:Configuration=Release -p:DeployExtension=false— clean build.Cracked the resulting
.vsixopen and confirmed:Resources\PerformanceStudioIcon.pngis packaged (11,818 bytes)<Icon>Resources\PerformanceStudioIcon.png</Icon>amd64andarm64InstallationTargets presentpngextension registered in[Content_Types].xml(required for the gallery to extract the icon)🤖 Generated with Claude Code