The nightly writes SHA256SUMS.txt with CRLF too - #2398
Merged
Conversation
#2384 fixed the release workflow and left the identical step in the nightly untouched, so every nightly since has shipped a checksum file that shasum -c cannot read on macOS or Linux. Verified against the published artifact rather than by reading the workflow: $ file nightly_SHA256SUMS.txt ASCII text, with CRLF line terminators $ head -1 nightly_SHA256SUMS.txt | cat -v f27860c5... PerformanceMonitorDarling-3.5.0-nightly.20260821.zip^M and with the artifact actually present, so the failure is the trailing CR and not a missing file: CRLF -> shasum: artifact.zip: No such file or directory artifact.zip: FAILED open or read LF -> artifact.zip: OK The nightly is arguably the worse of the two to get wrong. It is a prerelease, so the people downloading it are the ones most likely to verify a hash by hand, and "FAILED open or read" is indistinguishable from what a tampered download looks like. Same fix as #2384, with a note in both copies that a second one exists. Fixes #2383 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The defect was one of the two copies being updated without the other, so the cross-reference belongs on both sides or it only helps whoever happens to open the nightly first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Reviewed. This is a clean, minimal fix — the nightly checksum step now matches build.yml's |
erikdarlingdata
added a commit
that referenced
this pull request
Aug 21, 2026
Both were found by asking what in this release is verified by anything other than reading the diff. The checksum fix was half-applied (#2384 fixed the release workflow, not the nightly), and the dispatch-ref bug meant the release candidate I built to soak was not the branch I dispatched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2384 fixed
build.ymland left the identical step innightly.yml, so every nightly since has published a checksum file thatshasum -ccannot read.Found while auditing what in 3.5.1 is verified by anything other than reading the diff — this one is only exercised by actually running the pipeline, so I checked the published artifact:
And with the artifact present, so the failure is the trailing CR rather than a missing file:
The nightly is the worse of the two to get wrong. It is a prerelease, so whoever downloads it is disproportionately likely to check a hash by hand — and
FAILED open or readis exactly what a tampered download looks like.Same fix as #2384. Both copies now carry a note that the other exists, since the whole defect was one being updated without the other.