Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Windows end of line chars #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Windows end of line chars #53

wants to merge 1 commit into from

Conversation

vmahe35
Copy link

@vmahe35 vmahe35 commented Nov 20, 2020

I have noticed that some Windows EOL chars are present in many files.
You can see it by using for example cat -v src/main/functions/diameter.xml that displays strange chars at the end of each line.

It should be removed.
This is what I propose in this pull request.

@egwepas
Copy link
Contributor

egwepas commented Nov 20, 2020

Thanks,
I have two questions :

  • IDEs and GIT can both be used to support both EOL formats, do I don't know if this has to be fixed in source or if it is a development environment configuration issue.
  • Looks like dos2unix has also been applied to .bat files. Are they still working on windows ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmahe35 @egwepas @renovate35