Skip to content

need to use collections.abc.Sequence instead of collections.Sequence in python 3.10 and later #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

need to use collections.abc.Sequence instead of collections.Sequence in python 3.10 and later #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d70a1a
need to use collections.abc.Sequence instead of collections.Sequence …
lucasw Jan 8, 2023
16eb25b
remove support for python2 from package.xml
lucasw Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@

<author email="[email protected]">Eric Wieser</author>

<exec_depend condition="$ROS_PYTHON_VERSION == 2">python-numpy</exec_depend>
<exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-numpy</exec_depend>
<exec_depend>python3-numpy</exec_depend>
<exec_depend>rospy</exec_depend>
<exec_depend>sensor_msgs</exec_depend>
<exec_depend>nav_msgs</exec_depend>
Expand Down
2 changes: 1 addition & 1 deletion src/ros_numpy/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def numpify(msg, *args, **kwargs):
return

conv = _to_numpy.get((msg.__class__, False))
if not conv and isinstance(msg, collections.Sequence):
if not conv and isinstance(msg, collections.abc.Sequence):
if not msg:
raise ValueError("Cannot determine the type of an empty Collection")
conv = _to_numpy.get((msg[0].__class__, True))
Expand Down