[RFC] Add a search box#2
Open
alexjbest wants to merge 5 commits into
Open
Conversation
Author
|
@eric-wieser Do you have any more principled way of editing the code for this graph, i.e. do you generate it from typescript like it seems the Sigma demos do? |
Owner
|
No, that's #1 |
eric-wieser
reviewed
Jan 6, 2022
|
|
||
| // Feed the datalist autocomplete values: | ||
|
|
||
| searchSuggestions.innerHTML = graph.nodes().map(node=>"<option value=\"".concat(graph.getNodeAttribute(node, "label"), "\"></option>")).join("\n"); |
Owner
There was a problem hiding this comment.
I think we should sort these alphabetically
eric-wieser
reviewed
Jan 6, 2022
| // autocomplete: | ||
|
|
||
| if (suggestions.length === 1 && suggestions[0].label === query) { | ||
| state.selectedNode = suggestions[0].id; |
Owner
There was a problem hiding this comment.
Can you merge state.selectedNode and state.defaultNode? I think they achieve the same goal here.
eric-wieser
reviewed
Jan 6, 2022
| // we consider the user has selected a node through the datalist | ||
| // autocomplete: | ||
|
|
||
| if (suggestions.length === 1 && suggestions[0].label === query) { |
Owner
There was a problem hiding this comment.
This logic doesn't work for data.int.basic, which matches multiple nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to find stuff in the graph so I hacked together a search box from some sigma.js examples, what do you think?
It needs some tidying up but if you think its a nice addition we can definitely discuss what the best way to include it is.
See https://alexjbest.github.io/mathlib-import-graph/