Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove onchain 165 interface check during install #214

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

adamegyed
Copy link
Contributor

@adamegyed adamegyed commented Feb 12, 2025

Motivation

The ERC-6900 specification does not require that the account perform an ERC-165 interface check when installing a module, just that the module must implement that interface, Per a discussion in the working group and with the OpenZeppelin team, we will remove the onchain check during installation from the reference implementation to avoid encouraging this non-standard behavior.

Solution

Remove the ERC-165 interface check during _onInstall in ModuleManagerInternals.

Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • ModuleManagerInternals.sol: Removed interface checks from module installation and streamlined the _onInstall function without affecting its essential features.

🔗 Commit Hash: cafc5a7

This comment was marked as resolved.

@adamegyed adamegyed merged commit f1d6d01 into develop Feb 14, 2025
4 checks passed
@adamegyed adamegyed deleted the adam/remove-onchain-165-check branch February 14, 2025 17:13
@0xrubes
Copy link

0xrubes commented Feb 18, 2025

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants