Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename executeWithAuthorization to executeWithRuntimeValidation #184

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Sep 20, 2024

As discussed in our working group sync. executeWithRuntimeValidation more clearly conveys the function's purpose.

Note

I think we still need to clean up the authorization parameter name across the interfaces and the codebase. Sometimes we mean the additional data that should be provided to the validation function, and sometimes we mean the entire validation config (address + selector + additional auth data).

Copy link

octane-security-app bot commented Sep 20, 2024

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • ReferenceModularAccount.sol: Renamed executeWithAuthorization to executeWithRuntimeValidation to emphasize runtime validation over simple authorization.
  • KnownSelectors.sol: The smart contract's executeWithAuthorization function has been replaced with executeWithRuntimeValidation.
  • IModularAccount.sol: Renamed executeWithAuthorization to executeWithRuntimeValidation; maintains functionality while clarifying validation process.
  • IValidationHookModule.sol: Added an "authorization" parameter to the preRuntimeValidationHook function for additional validation data usage.
  • ReturnDataModuleMocks.sol: Primary functionality updated to use executeWithRuntimeValidation instead of executeWithAuthorization for result checking.
  • AccountTestBase.sol: Primary functionality updated from executeWithAuthorization to executeWithRuntimeValidation.

🔗 Commit Hash: 6fe9bac

@jaypaik jaypaik requested a review from a team September 20, 2024 15:56

This comment was marked as resolved.

Copy link
Contributor

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small nit

@jaypaik jaypaik merged commit 0bb2bfa into develop Sep 20, 2024
4 checks passed
@jaypaik jaypaik deleted the 09-20-feat_rename_executeWithAuthorization_to_executeWithRuntimeValidation branch September 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants