chore: update headings #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0dot
reviewed
Aug 30, 2024
Zer0dot
reviewed
Aug 30, 2024
standard/ERCs/erc-6900.md
Outdated
| During validation uninstallation, the account MUST correctly clear flags and other fields based on the incoming data provided by the user. | ||
|
|
||
| - the account MUST clear all flags for the validation function, like `isGlobal`, `isSignatureValidation`, and `isUserOpValidation`. | ||
| - the account MUST remomve all hooks and SHOULD clear hook module states by calling `onUninstall` with the user-provided data for each hook, including both pre validation hooks and permission hooks, if required by user. | ||
| - the account MUST remove all selectors that the validation function can validate. | ||
| - the account MUST emit `ValidationUninstalled` as defined in the interface for all uninstalled validations. | ||
|
|
||
| #### Execution and their installation /uninstallation | ||
| ### Execution and their installation /uninstallation |
There was a problem hiding this comment.
Suggested change
| ### Execution and their installation /uninstallation | |
| ### Execution and Their Installation/Uninstallation |
Zer0dot
reviewed
Aug 30, 2024
standard/ERCs/erc-6900.md
Outdated
| @@ -527,7 +533,7 @@ During execution uninstallation, the account MUST correctly clear flags and othe | |||
| - the account SHOULD call `onUnInstall` on the execution module to initialize the states and track call success if required by user. | |||
| - the account MUST emit `ExecutionUninstalled` as defined in the interface for all uninstalled executions. | |||
|
|
|||
| #### Hook execution order | |||
| ### Hook execution order | |||
There was a problem hiding this comment.
Suggested change
| ### Hook execution order | |
| ### Hook Execution Order |
Zer0dot
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the sections headings under specification were wrong.
Solution
Fix and improve heading under specification.