Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add everest-models as a package installation when building readthedocs for everest #9940

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Feb 3, 2025

Issue
Resolves #9930

Approach
Add everest-models as a package installation when building readthedocs for everest

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Feb 3, 2025
@DanSava DanSava added release-notes:skip If there should be no mention of this in release notes release-notes:documentation PR with only changes to documentation labels Feb 3, 2025
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #9940 will not alter performance

Comparing DanSava:fix-readthedocs-everest (da3d3b8) with main (7c27a9c)

Summary

✅ 25 untouched benchmarks

@DanSava DanSava force-pushed the fix-readthedocs-everest branch 5 times, most recently from 768860f to 8b2a4ec Compare February 3, 2025 10:37
@DanSava DanSava force-pushed the fix-readthedocs-everest branch from 8b2a4ec to da3d3b8 Compare February 3, 2025 10:40
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested building docs and it seems to work on my machine

@DanSava DanSava merged commit 5f7a11a into equinor:main Feb 3, 2025
27 checks passed
@DanSava DanSava deleted the fix-readthedocs-everest branch February 3, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:documentation PR with only changes to documentation release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No forward model documentation built in readthedocs
2 participants