Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross threshold when choosing components pca #9874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 24, 2025

Highlights one issue with using PCA to decide the number of clusters to use. If you have say 20 observations, where 19 of them are highly correlated and the last observation is independent of the others, then 1 principal component which is a linear combination of these 19 might be enough to explain more than 95% of the variance, and the algorithm would then decide on 1 cluster.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #9874 will improve performances by 13.41%

Comparing larsevj:cross_threshold_when_choosing_components_pca (4a0ea64) with main (6ba3112)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.4 ms +13.41%

@larsevj larsevj force-pushed the cross_threshold_when_choosing_components_pca branch from b9b269c to e5b445f Compare January 30, 2025 12:12
@larsevj larsevj force-pushed the cross_threshold_when_choosing_components_pca branch from e5b445f to 4a0ea64 Compare February 4, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant