Skip to content

Set ensemble size from design matrix #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

larsevj
Copy link
Collaborator

@larsevj larsevj commented Mar 20, 2025

Also changes the wording in the GUI from Number of realizations to Ensemble size

Changes in gui:
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10406 will not alter performance

Comparing larsevj:set_ensemble_size_from_design_matrix (78da766) with main (97e4b3a)

Summary

✅ 25 untouched benchmarks

@larsevj larsevj force-pushed the set_ensemble_size_from_design_matrix branch from e4d25e0 to 87bc42a Compare March 20, 2025 15:56
@larsevj
Copy link
Collaborator Author

larsevj commented Mar 21, 2025

Hover info (on mac):
image

@larsevj larsevj force-pushed the set_ensemble_size_from_design_matrix branch from 87bc42a to fd70091 Compare March 21, 2025 08:34
@larsevj larsevj marked this pull request as ready for review March 21, 2025 08:35
@larsevj larsevj force-pushed the set_ensemble_size_from_design_matrix branch 2 times, most recently from 4b7d128 to 9558f65 Compare March 21, 2025 09:29
@oyvindeide
Copy link
Collaborator

Tested this, and got some strange behavior, I have this design matrix in the poly example:

REAL | a | b
   0 | 0 | 2
   1 | 0 | 2
   2 | 0 | 2
   3 | 0 | 2

then I start ert and select Ensemble experiment, immediately the Ensemble size shows what I would expect, with the warning, however if I decrease the active realizations from 0-3 -> 0-2, Ensemble size jumps to 100, I would expect 3.

@larsevj larsevj force-pushed the set_ensemble_size_from_design_matrix branch from 4c3ffb0 to 0208a38 Compare March 28, 2025 11:44
@larsevj
Copy link
Collaborator Author

larsevj commented Mar 28, 2025

Tested this, and got some strange behavior, I have this design matrix in the poly example:

REAL | a | b
   0 | 0 | 2
   1 | 0 | 2
   2 | 0 | 2
   3 | 0 | 2

then I start ert and select Ensemble experiment, immediately the Ensemble size shows what I would expect, with the warning, however if I decrease the active realizations from 0-3 -> 0-2, Ensemble size jumps to 100, I would expect 3.

This should be fixed now ( for ensemble experiment), not sure what to do with the warning label though it will currently only be set if the ensemble_size is different on initialization.

@larsevj larsevj force-pushed the set_ensemble_size_from_design_matrix branch from 38748df to 78da766 Compare April 1, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants