-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 26 packages #163
base: main
Are you sure you want to change the base?
Update 26 packages #163
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-163 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-04-01 07:32:12 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI on the plot fig/delays-functions-rendered-unnamed-chunk-17-1.png
have changed quite dramatically. Is this expected?
b2ec9db#diff-c8ccb4af4f83edac20865ecd44127afcd1986c35efb7c98399c6684abccc0897
Yes, it is something that I found in the most recent PR md outputs from the last month, but could not reproduce it to report to package maintainers. Even if I got an expected output in one workflow, after many other repetitions, after merging a PR, I got unexpectedly wider CIs at main. The output message from the previous run suggest that we can stabilize it by setting a fixed set of stan parameters (samples and chains), as in the quantify-transmission episode. EpiNow2::epinow(
...,
stan = EpiNow2::stan_opts(samples = 1000, chains = 3)
) @jamesmbaazam from the epinow() output warning message below, we get the figure on the left (unexpected wide CIs), but we get the expected output (figure on the right) without any output message. Should we expect to make this output stable by setting fixed stan samples and chains only? From the warning message, would you suggest that we fix another set of parameters?
|
Thanks for tagging @avallecam. I'll take a closer look next week. We have a similar issue in our scheduled rendering of vignettes in https://github.com/epiforecasts/EpiNow2/pull/1060/files. Looks quite strange. |
🤖 This is an automated build
This will update 26 packages in your lesson with the following versions:
⏱️ In a few minutes, a comment will appear that will show you how the output has changed based on these updates.
If you want to inspect these changes locally, you can use the following code to check out a new branch: