-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hmisc dependency #273
base: cran-fixes
Are you sure you want to change the base?
Conversation
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
1 similar comment
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cran-fixes #273 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 6 6
Lines 1015 1017 +2
============================================
+ Hits 1015 1017 +2 ☔ View full report in Codecov by Sentry. |
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
This pull request:
(Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual control indicates this change returns the same value as in main
, as desired.
It might however be good to add a snapshot test on prepare_serosurvey_for_plotting()
to formally confirm this here and in future changes. What do you think?
This PR removes Hmisc as a dependency. So far, we were using
Hmisc::binconf
to compute the binomial confidence interval according to the Clopper-Pearson method. As pointed out by @Bisaloo in #174, this is a very heavy dependency to be used only for this purpose.Now, the binomial confidence interval is computed by means of dependencies already present in the packages, namely
purrr
andstats
. I adapted the code from this post to our needs and it yields similar results as before.