Skip to content

add explicit key prop to JSX element #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ScottDalessandro
Copy link

@ScottDalessandro ScottDalessandro commented Feb 28, 2025

Please check Issue

Test Plan

On a new epic stack instance, visit and click the new note page visiting /users/:username/notes/new and the browser console should be empty with errors:

image

Checklist

  • Tests updated: No
  • Docs updated: No

Screenshots

Before (when creating a new note)

image

After:

image

Copy link
Contributor

@updbqn updbqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think conform expects us to use the key from field for everything to work correctly.

See e.g. edmundhung/conform#600 (comment)

@ScottDalessandro
Copy link
Author

Nice find, thanks! So the option here is to ignore them. I'll try to make a demo production version of this. I'd presume React would suppress these errors in production and we'll only have to deal with them in dev environments.

@braginteractive braginteractive mentioned this pull request Mar 16, 2025
@zwhitchcox
Copy link
Contributor

zwhitchcox commented Apr 21, 2025

This should be fixed by edmundhung/conform#837, but will need to upgrade to 1.4.0

@zwhitchcox zwhitchcox mentioned this pull request Apr 21, 2025
@kentcdodds kentcdodds closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants