Simplify soft assertion example and narrative #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an pass a day argument too!
…e, there was a bug in the monthly subscriptions and we didn't handle yearly subscriptions. Now, the bug is simply that we handle monthly subscriptions, but not yearly subscriptions.
kettanaito
reviewed
May 12, 2025
| today.setUTCMonth(today.getUTCMonth() + 1, 1) | ||
| break; | ||
| case "yearly": | ||
| today.setUTCFullYear(today.getUTCFullYear() + 1, 0, 1) |
There was a problem hiding this comment.
I appreciate the realism here but the subscription logic is largely irrelevant for the exercise. For example, it might as well be that in this app the yearly subscription still expires on the first day of the next month once you cancel it, and you get refunded the unused credits. That doesn't really matter.
But what I want to try to do with your feedback is make the actions of the exercise more streamlined. Thinking about that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When doing the exercise on soft assertions, I found it confusing how to correct the source code, because there were multiple bugs and it wasn't clear what the solution wanted us to do.
The bugs were:
Also, the solution was a bit overcomplicated (
setUTCMonthhandles year changes, i.e you can dotoday.setUTCMonth(20)to set it to 20 months after the first day of that year), which I think brings the attention away from vitest and soft assertionsProposed solution
Let's simplify the logic so that the bug is a bit more straightforward to fix:
endAtpropertyGoing further
Maybe we'd want a test for the
TrialPlanto guide the students further / provide more context?