feat(chat): implement apps editor on separated route (Issue #3146) #2669
Conversation
Co-authored-by: Magomed-Elbi Dzhukalaev <[email protected]>
…to feat/quick-apps
…upport dynamic slugs
… with tab navigation
…plication settings
…ent for improved preview functionality
…related components
…onfiguration and add QuickAppView component
|
/deploy-review
|
| visualizer.current = new VisualizerConnector(containerRef.current, { | ||
| domain: iframeUrl, | ||
| hostDomain: window.location.origin, | ||
| visualizerName: title, | ||
| }); |
There was a problem hiding this comment.
Should we destroy if props have changed to avoid memory leak?
| visualizer.current = new VisualizerConnector(containerRef.current, { | |
| domain: iframeUrl, | |
| hostDomain: window.location.origin, | |
| visualizerName: title, | |
| }); | |
| if (visualizer.current) { | |
| visualizer.current.destroy(); | |
| } | |
| visualizer.current = new VisualizerConnector(containerRef.current, { | |
| domain: iframeUrl, | |
| hostDomain: window.location.origin, | |
| visualizerName: title, | |
| }); |
|
/deploy-review
|
… into feat/apps-editor-route
| //code app application properties | ||
| sources: applicationData?.function?.source_folder | ||
| ? ApiUtils.decodeApiUrl(applicationData.function.source_folder) | ||
| : `files/${bucket}/appdata`, |
There was a problem hiding this comment.
Source folder should be empty as default. We have 'examples' if we don't have files in the selected directory. If we click on some example application now, we will create these files in the /appdata directory which is not supposed to be used that way.
| return { | ||
| name: | ||
| applicationData?.display_name ?? | ||
| getNextDefaultName(DEFAULT_APPLICATION_NAME, models ?? [], 0, true), |
There was a problem hiding this comment.
Need to dispatch getModels on page load, otherwise we will get error on trying to create an application with default name if we open apps-editor page without navigating to it from marketplace
| app: applicationData, | ||
| runtime: pythonVersions[0], | ||
| }), | ||
| ['Quick App']: getQuickAppDefaultValues({ |
There was a problem hiding this comment.
Quick app settings tab does not open and show infinite loader instead.
When quick app editor is open, type equals to 'QuickApps', not 'Quick App'. Same for line 130.
It's better to map this to ApplicationType enum here also.
There was a problem hiding this comment.
This is a temporary solution until Quick App has a custom editor.
… into feat/apps-editor-route
…ty and update related logic
|
/deploy-review
|
…tion status handling (#3186)
… into feat/apps-editor-route
Description:
implement apps editor on separated route
Issues:
UI changes
Checklist:
fix(<scope>):,feat(<scope>):,feature(<scope>):,chore(<scope>):,hotfix(<scope>):ore2e(<scope>):. If contains breaking changes then the pull request name must start withfix(<scope>)!:,feat(<scope>)!:,feature(<scope>)!:,chore(<scope>)!:,hotfix(<scope>)!:ore2e(<scope>)!:where<scope>is name of affected project:chat,chat-e2e,overlay,shared,sandbox-overlay, etc.(Issue #<TICKET_ID>)(comma-separated list of issues)