Skip to content

Commit

Permalink
feat/workspace-bookmarked-agents-search-tests: fixed elements count a…
Browse files Browse the repository at this point in the history
…ssertion
  • Loading branch information
irinakartun committed Feb 18, 2025
1 parent bdbf9e1 commit b06a749
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apps/chat-e2e/src/assertions/base/baseAssertion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class BaseAssertion {
expectedCount: number,
expectedMessage?: string,
) {
const elementsCount = this.getElement(element);
const elementsCount = await this.getElement(element).count();
expect
.soft(
elementsCount,
Expand Down
5 changes: 2 additions & 3 deletions apps/chat-e2e/src/tests/isolatedView.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ dialTest(
'EPMRTC-4889',
);
let nonWorkspaceModel: DialAIEntityModel;
let installedDeployments: { id: string }[];
let models: DialAIEntityModel[];
let chatName: string;

Expand All @@ -284,15 +283,15 @@ dialTest(

nonWorkspaceModel = GeneratorUtil.randomArrayElement(
models.filter((model) => {
const isNotInstalled = !installedDeployments.some(
const isNotInstalled = !randomModels.some(
(deployment) => deployment.id === model.id,
);
const hasNoColon = !model.id.includes(':');
return isNotInstalled && hasNoColon;
}),
);

const recentModelsToAdd = installedDeployments
const recentModelsToAdd = randomModels
.map((deployment) =>
models.find((model) => model.id === deployment.id),
)
Expand Down

0 comments on commit b06a749

Please sign in to comment.