Fixup filename and extension extraction to handle dotfile filenames #204
Conversation
|
Code Climate has analyzed commit 2a98dca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
|
Thank you for your contribution. e.g. I think the extension of I think it's a problem that the plugin can't lint filenames that start with a dot, so I'd like to fix it. |
| @@ -9,6 +9,7 @@ ruleTester.run('naming-convention', namingConvention, { | |||
| { code: '', filename: 'kebab-case.js' }, | |||
| { code: '', filename: 'index.js', options: [{ rule: 'PascalCase' }] }, | |||
| { code: '', filename: 'index.js', options: [{ rule: '[a-z]*' }] }, | |||
| { code: '', filename: '.eslintrc.js', options: [{ excepts: ['\..+'] }] }, | |||
There was a problem hiding this comment.
Looking at this line, I thought you might just want to remove the file from the target of rule/naming-convention.
If so, you can override the rules for the specific file in eslintrc.
module.exports = {
...
overrides: [
{
files: ['.eslintrc.js'],
plugins: ['filenames-simple'],
rules: {
'filenames-simple/naming-convention': 'off'
}
}
]
};
Related issue numbers
About the pull request
Fixes filename and extension extraction so that dotfile filenames are handled.
Additional context
It was previously throwing a 'The filename is empty' errors on dotfiles (e.g.: .eslintrc.js) and the 'excepts' option could not be used to suppress this because the filename length check validation occurs prior.