Skip to content

Make setup.cfg the runtime dependency source for tests and enforce runtime-dep placement in macros #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Make setup.cfg the runtime dependency source for tests and enforce runtime-dep placement in macros #4532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e4e75d
Initial plan
Copilot May 14, 2026
bb718b3
refactor macros to derive runtime test deps from setup.cfg
Copilot May 14, 2026
b65b835
ci/python: Add wheel metadata publishing validation
phlax May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/py.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ jobs:
named-caches-hash: "${{ hashFiles('pants*toml') }}"
- name: Run pants package
run: "pants --colors package ::"
- name: Verify wheel METADATA matches setup.cfg
run: |
python -m pip install --quiet packaging
python py/tools/publish_check/check_wheel_metadata.py
- name: Archive wheels
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
Expand Down
5 changes: 0 additions & 5 deletions py/_test_publish_pkg/_test_publish_pkg/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@

target(
name="dev_deps",
dependencies=[
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#packaging",
"//py/deps:reqs#pyyaml",
],
)

toolshed_library(
Expand Down
5 changes: 0 additions & 5 deletions py/aio.api.bazel/aio/api/bazel/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@

toolshed_library(
"aio.api.bazel",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
],
sources=[
"abstract/__init__.py",
"abstract/base.py",
Expand Down
9 changes: 1 addition & 8 deletions py/aio.api.bazel/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@

toolshed_tests(
"aio.api.bazel",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
],
)
toolshed_tests("aio.api.bazel")
7 changes: 0 additions & 7 deletions py/aio.api.github/aio/api/github/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@

toolshed_library(
"aio.api.github",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#gidgethub",
"//py/deps:reqs#packaging",
],
sources=[
"abstract/__init__.py",
"abstract/actions/__init__.py",
Expand Down
5 changes: 0 additions & 5 deletions py/aio.api.github/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
toolshed_tests(
"aio.api.github",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#gidgethub",
"//py/deps:reqs#packaging",
"//py/deps:reqs#pytest-asyncio",
],
)
6 changes: 0 additions & 6 deletions py/aio.api.nist/aio/api/nist/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@

toolshed_library(
"aio.api.nist",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#packaging",
],
sources=[
"abstract/__init__.py",
"abstract/cpe.py",
Expand Down
7 changes: 1 addition & 6 deletions py/aio.api.nist/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@

toolshed_tests(
"aio.api.nist",
dependencies=[
"//py/deps:reqs#abstracts",
],
)
toolshed_tests("aio.api.nist")
9 changes: 1 addition & 8 deletions py/aio.core/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@

toolshed_tests(
"aio.core",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#pyyaml",
"//py/deps:reqs#trycast",
],
)
toolshed_tests("aio.core")
3 changes: 0 additions & 3 deletions py/aio.run.checker/aio/run/checker/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@

toolshed_library(
"aio.run.checker",
dependencies=[
"//py/deps:reqs#aio-run-runner",
],
)
7 changes: 1 addition & 6 deletions py/aio.run.checker/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@

toolshed_tests(
"aio.run.checker",
dependencies=[
"//py/deps:reqs#aio-run-runner",
],
)
toolshed_tests("aio.run.checker")
8 changes: 0 additions & 8 deletions py/aio.run.runner/aio/run/runner/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@

toolshed_library(
"aio.run.runner",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#coloredlogs",
"//py/deps:reqs#frozendict",
"//py/deps:reqs#uvloop",
"//py/deps:reqs#verboselogs",
],
)
8 changes: 1 addition & 7 deletions py/aio.run.runner/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,2 @@

toolshed_tests(
"aio.run.runner",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
],
)
toolshed_tests("aio.run.runner")
5 changes: 0 additions & 5 deletions py/dependatool/dependatool/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@

toolshed_library(
"dependatool",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-checker",
],
sources=[
"__init__.py",
"abstract/__init__.py",
Expand Down
17 changes: 0 additions & 17 deletions py/envoy.base.utils/envoy/base/utils/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@

toolshed_library(
"envoy.base.utils",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-api-github",
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#frozendict",
"//py/deps:reqs#jinja2",
"//py/deps:reqs#orjson",
"//py/deps:reqs#packaging",
"//py/deps:reqs#protobuf",
"//py/deps:reqs#python-gnupg",
"//py/deps:reqs#pyyaml",
"//py/deps:reqs#trycast",
"//py/deps:reqs#types-protobuf",
"//py/deps:reqs#zstandard",
],
sources=[
"__init__.py",
"abstract/__init__.py",
Expand Down
6 changes: 0 additions & 6 deletions py/envoy.base.utils/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ toolshed_tests(
"envoy.base.utils",
dependencies=[
":data",
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-api-github",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#pyyaml",
"//py/deps:reqs#trycast",
],
)

Expand Down
6 changes: 0 additions & 6 deletions py/envoy.ci.report/envoy/ci/report/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@

toolshed_library(
"envoy.ci.report",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-api-github",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
],
sources=[
"__init__.py",
"ci.py",
Expand Down
8 changes: 1 addition & 7 deletions py/envoy.ci.report/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,2 @@

toolshed_tests(
"envoy.ci.report",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
],
)
toolshed_tests("envoy.ci.report")
8 changes: 0 additions & 8 deletions py/envoy.code.check/envoy/code/check/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,7 @@
toolshed_library(
"envoy.code.check",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-checker",
"//py/envoy.base.utils/envoy/base/utils",
"//py/deps:reqs#flake8",
"//py/deps:reqs#packaging",
"//py/deps:reqs#yamllint",
"//py/deps:reqs#yapf",
"//py/deps:reqs#types-pyyaml",
],
sources=[
"__init__.py",
Expand Down
7 changes: 0 additions & 7 deletions py/envoy.code.check/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@
toolshed_tests(
"envoy.code.check",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-checker",
"//py/envoy.base.utils/envoy/base/utils",
"//py/deps:reqs#flake8",
"//py/deps:reqs#packaging",
"//py/deps:reqs#pep8-naming",
"//py/deps:reqs#yapf",
],
)
11 changes: 0 additions & 11 deletions py/envoy.dependency.check/envoy/dependency/check/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@

toolshed_library(
"envoy.dependency.check",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-api-github",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-checker",
"//py/deps:reqs#envoy-base-utils",
"//py/deps:reqs#gidgethub",
"//py/deps:reqs#jinja2",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#packaging",
],
sources=[
"abstract/__init__.py",
"abstract/checker.py",
Expand Down
13 changes: 1 addition & 12 deletions py/envoy.dependency.check/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,2 @@

toolshed_tests(
"envoy.dependency.check",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-api-github",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-checker",
"//py/deps:reqs#envoy-base-utils",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#packaging",
],
)
toolshed_tests("envoy.dependency.check")
5 changes: 0 additions & 5 deletions py/envoy.distribution.release/envoy/distribution/release/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@
toolshed_library(
"envoy.distribution.release",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#envoy-base-utils",
"//py/envoy.github.release/envoy/github/abstract",
"//py/deps:reqs#envoy-github-release",
],
tags=["abstract-types"],
)
1 change: 0 additions & 1 deletion py/envoy.distribution.release/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ toolshed_tests(
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/envoy.github.release/envoy/github/abstract",
"//py/deps:reqs#envoy-github-release",
],
)
2 changes: 0 additions & 2 deletions py/envoy.distribution.verify/envoy/distribution/verify/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
toolshed_library(
"envoy.distribution.verify",
dependencies=[
"//py/deps:reqs#aio-run-checker",
"//py/deps:reqs#envoy-base-utils",
"//py/envoy.distribution.verify/envoy/distribution/distrotest",
],
)
2 changes: 0 additions & 2 deletions py/envoy.distribution.verify/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
toolshed_tests(
"envoy.distribution.verify",
dependencies=[
"//py/deps:reqs#aio-run-checker",
"//py/deps:reqs#envoy-base-utils",
"//py/envoy.distribution.verify/envoy/distribution/distrotest",
],
)
3 changes: 0 additions & 3 deletions py/envoy.docker.utils/envoy/docker/utils/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
toolshed_library(
"envoy.docker.utils",
dependencies=[
"//py/deps:reqs#aiodocker",
],
)
18 changes: 0 additions & 18 deletions py/envoy.docs.sphinx_runner/envoy/docs/sphinx_runner/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,6 @@

toolshed_library(
"envoy.docs.sphinx_runner",
dependencies=[
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#envoy-base-utils",
"//py/deps:reqs#colorama",
"//py/deps:reqs#docutils",
"//py/deps:reqs#packaging",
"//py/deps:reqs#protobuf",
"//py/deps:reqs#pygments",
"//py/deps:reqs#sphinx",
"//py/deps:reqs#sphinx-copybutton",
"//py/deps:reqs#sphinx-rtd-theme",
"//py/deps:reqs#sphinx-tabs",
"//py/deps:reqs#sphinxcontrib-jquery",
"//py/deps:reqs#sphinxcontrib-httpdomain",
"//py/deps:reqs#sphinxcontrib-serializinghtml",
"//py/deps:reqs#sphinxext-rediraffe",
"//py/deps:reqs#types-pygments",
],
sources=[
"__init__.py",
"cmd.py",
Expand Down
14 changes: 1 addition & 13 deletions py/envoy.docs.sphinx_runner/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,2 @@

toolshed_tests(
"envoy.docs.sphinx_runner",
dependencies=[
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#envoy-base-utils",
"//py/deps:reqs#colorama",
"//py/deps:reqs#sphinx",
"//py/deps:reqs#sphinx-copybutton",
"//py/deps:reqs#sphinxcontrib-httpdomain",
"//py/deps:reqs#sphinxcontrib-serializinghtml",
"//py/deps:reqs#sphinxext-rediraffe",
],
)
toolshed_tests("envoy.docs.sphinx_runner")
10 changes: 0 additions & 10 deletions py/envoy.github.release/envoy/github/release/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,7 @@
toolshed_library(
"envoy.github.release",
dependencies=[
"//py/deps:reqs#abstracts",
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
"//py/deps:reqs#aiohttp",
"//py/deps:reqs#aiofiles",
"//py/deps:reqs#gidgethub",
"//py/deps:reqs#packaging",
"//py/deps:reqs#verboselogs",
"//py/envoy.github.release/envoy/github/abstract",
"//py/deps:reqs#envoy-base-utils",
"//py/deps:reqs#types-aiofiles",
],
tags=["abstract-types"],
sources=[
Expand Down
2 changes: 0 additions & 2 deletions py/envoy.github.release/tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
toolshed_tests(
"envoy.github.release",
dependencies=[
"//py/deps:reqs#aio-core",
"//py/deps:reqs#aio-run-runner",
"//py/envoy.github.release/envoy/github/abstract",
],
)
Loading
Loading