Add DNS query Trace of NotStarted before queuing. #38186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it was possible that the `addTrace(NotStarted)` occured after the resolver thread picked up the query and started work. This can be seen when running the getaddrinfo tests 1000 times in the form of failure around or just under 1% of the time. bazel test --config=libc++ --runs_per_test 1000 //test/extensions/network/dns_resolver/getaddrinfo:getaddrinfo_test Signed-off-by: Alejandro R. Sedeño <[email protected]>
alyssawilk
approved these changes
Jan 27, 2025
bazmurphy
pushed a commit
to bazmurphy/envoy
that referenced
this pull request
Jan 29, 2025
Before this change, it was possible that the `addTrace(NotStarted)` occured after the resolver thread picked up the query and started work. This can be seen when running the getaddrinfo tests 1000 times in the form of failure around or just under 1% of the time. ``` bazel test --config=libc++ --runs_per_test 1000 //test/extensions/network/dns_resolver/getaddrinfo:getaddrinfo_test ``` Risk Level: low Testing: CI Signed-off-by: Alejandro R. Sedeño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it was possible that the
addTrace(NotStarted)occured after the resolver thread picked up the query and started work. This can be seen when running the getaddrinfo tests 1000 times in the form of failure around or just under 1% of the time.Risk Level: low
Testing: CI