-
Notifications
You must be signed in to change notification settings - Fork 12
moving fallback RPC section & hypersyc url change #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR reorganizes RPC fallback documentation by moving content from the hypersync.md file to rpc-sync.md, updates related hyperlinks to reference the new location, and corrects a HyperSync client initialization URL endpoint in example code. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes These are entirely documentation changes—content reorganization, link updates, and a URL endpoint correction—with no code logic or functional behavior modifications. The changes are straightforward and consistent in nature. Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to move this here.
The rpc as a fallback is mostly to address a hypersync issue, so in my mind, it's more something that's shown for when you're reading the hypersync source doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moose-code thought it was somewhat confusing that this section was under hypersync. Since RPC fallback is more closely related to RPC as a data source, I moved that section to where it felt like a better fit. Also, having all RPC-related things in one place is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree. I think it's important for users understanding HyperSync to know that there is an option for an RPC fallback.
I am happy to be overruled here. I would suggest that you ask JJ to review this PR.
| client = hypersync.HypersyncClient( | ||
| hypersync.ClientConfig( | ||
| url="https://ethereum.hypersync.xyz", | ||
| url="https://eth.hypersync.xyz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
The pr title says reorg pages, do you mean rpc fallback or is there something missing from this pr |
|
@DenhamPreen I wanted to say reorganization of that particular section, not the pages. I have updated the title to "moving fallback RPC section" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikbhintade going to preapprove but just ask you add a small section back in the hypersync side that points towards this so users will find this if they look in hypersync or rpc
|
yeah, I will add that section |
Summary by CodeRabbit