Update to GraalVM 25 #14019

Akirathan · 2025-09-17T12:59:18Z

Closes #13918

Pull Request Description

Update GraalVM from no longer supported 24.0.1 to 25.0.0 - e.g. the LTS version.

Important Notes

NI size decreased by 6%

Highlights from GraalVM 25 release notes:

FFM API support on aarch64
Implemented Arena.ofShared
Experimental Native image tracing agent
Experimental -H:+JDWP flag.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Otherwise engine-runner NI build fails.

Otherwise, NI build fails with "Substitution target for com.oracle.svm.core.posix.darwin.Target_java_util_prefs_FileSystemPreferences is not loaded".

Akirathan · 2025-09-22T13:04:54Z

NI build of engine-runner is successful. Its size is 533 MB. The previous size (for example built here) was 568 MB.

So just by upgrading to GraalVM 25.0.0, the NI size decreased by roughly 6%.

Akirathan · 2025-09-22T13:14:12Z

Failure in std-table/test: Mockito failure: "Java 25 not supported" at https://github.com/enso-org/enso/actions/runs/17914034971/job/50933411374?pr=14019#step:14:2018.

Fixed by bumping Mockito version in 6ac2d05

Which supports Java 25.

#14019 is blocked by this - the current google java format version is failing because it tries to call remove method from JDK - see https://github.com/enso-org/enso/actions/runs/17916525266/job/50940077628?pr=14019#step:5:245 # Important Notes The only notable change is in ff3fec5 . Every thing else is just automatic `sbt javafmtAll` formatting.

hubertp

enso.{def,exp,lib} files must not be in the top directory. It's a packaging thing so probably somewhere in the distribution/resources directory?
Instructions to generate them should also be added either as a comment in the files (probably not possible) or in some docs related to distribution. PR comment is not really enough.

JaroslavTulach · 2025-10-28T06:32:29Z

enso.{def,exp,lib} files must not be in the top directory. It's a packaging thing so probably somewhere in the distribution/resources directory?

Maybe next to the shell scripts - these files are kind of same beasts...
I was also considering to download it form github resources like we do with pictures
moved in 2d4d19e

Instructions to generate ... PR comment is not really enough.

Right. PR comment is certainly not enough.... I cannot find it right now. Done in 0e2e247

JaroslavTulach

CI seems to be green
the hack with enso.lib has been reviewed by Hubert
let's move on and switch to LTS version of GraalVM

engine/runner/src/main/java/org/enso/runner/EnsoLibraryFeature.java

project/GraalVM.scala

JaroslavTulach · 2025-10-28T13:26:12Z

distribution/bin/enso.lib

also generated from enso.def

https://github.com/enso-org/enso/pull/14019/files#r2461574134

JaroslavTulach · 2025-10-28T13:29:10Z

distribution/bin/enso.def

@@ -0,0 +1,40 @@
+NAME "enso.exe"
+
+;


These are the instructions to generate enso.exp and enso.def files.

JaroslavTulach · 2025-10-28T17:49:14Z

Also checking extra nightly tests

JaroslavTulach · 2025-10-29T07:02:42Z

Another Java heap space error on Mac OS X when running JVM tests

 Test run org.enso.interpreter.test.NativeLibraryFinderTest finished: 0 failed, 0 ignored, 4 total, 287.39s
 Test org.enso.interpreter.test.PolyglotErrorTest failed: org.enso.test.utils.ContextUtils$FailureWithOutput: Compiler output: , took 0.0 sec
      at org.enso.test.utils.ContextUtils$CustomStatement.evaluate(ContextUtils.java:476)
      ...
 Caused by: java.lang.RuntimeException: org.graalvm.polyglot.PolyglotException: Java heap space: failed reallocation of scalar replaced objects
      at org.enso.test.utils.ContextUtils$CustomStatement.lambda$evaluate$0(ContextUtils.java:468)
      at org.enso.test.utils.ContextUtils.lambda$executeInContext$0(ContextUtils.java:294)
      at org.graalvm.polyglot.Engine$APIAccessImpl.callProxyExecutableExecute(Engine.java:1532)
      at com.oracle.truffle.host.GuestToHostCodeCache$1.executeImpl(GuestToHostCodeCache.java:126)
      at com.oracle.truffle.host.GuestToHostRootNode.execute(GuestToHostRootNode.java:80)

the test itself succeeds when executed locally in isolation with runtime-integration-tests/testOnly *PolyglotErrorTest on my Intel Mac - e.g. it is either random failure or caused by some garbage being allocated by other tests.

JaroslavTulach · 2025-10-29T08:07:11Z

There is also

[error] Test org.enso.interpreter.test.meta.QualifiedNameTest.qualifiedTypeNameWorks_WhenRunningSingleFile failed: java.lang.AssertionError: 
[error] Expected: is "local.Proj.Main.My_Type"
[error]      but: was "local.Proj.........................private.var.folders.36.74fmy6d51s9ct3v8lskdy07r0000gn.T.junit12491882196538959277.junit2501126755569952691.src.Main.My_Type", took 7.405 sec
[error]     at org.enso.interpreter.test.meta.QualifiedNameTest.lambda$qualifiedTypeNameWorks_WhenRunningSingleFile$0(QualifiedNameTest.java:34)
[error]     at org.enso.test.utils.ProjectUtils.testProjectRun(ProjectUtils.java:137)

failure which is real, isolated and reproducible. Related to some trickery around temporary directory on Mac. Fixed by 8031779

JaroslavTulach · 2025-10-29T09:27:26Z

Running the tests on Mac locally:

sbt:enso> runtime-integration-tests/test
[info] Test run org.enso.interpreter.test.AnyOrStaticTest finished: 0 failed, 0 ignored, 2 total, 1.531s
[info] ScalaTest
[info] Run completed in 9 minutes, 18 seconds.
[info] Total number of tests run: 1372
[info] Suites: completed 101, aborted 0
[info] Tests: succeeded 1372, failed 0, canceled 0, ignored 3, pending 30
[info] All tests passed.
[info] Passed: Total 27280, Failed 0, Errors 0, Passed 27280, Ignored 32, Pending 30
[success] Total time: 571 s (09:31), completed 29. 10. 2025 10:09:06

e.g. things are working and I believe we can integrate regardless of state of Mac CI (which was already almost green). Adding ready to merge label.

Akirathan added 2 commits September 17, 2025 14:57

Graal Version can be just a single number

fb4e679

Upgrade graalVersion and graalMavenPackageVersion in build.sbt

2646d45

Akirathan self-assigned this Sep 17, 2025

Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Sep 17, 2025

Lift graal dir name assumption

3a87b30

JaroslavTulach mentioned this pull request Sep 19, 2025

Replace synchronization blocks in polyglot Java initialization #13907

Open

5 tasks

enso-bot bot mentioned this pull request Sep 19, 2025

Register only static methods during compilation #11686

Open

Akirathan added 9 commits September 19, 2025 16:55

Add truffle-nfi-panama dependency of graalpy

af234fd

Remove deprecated RunReachabilityHandlersConcurrently option

ad58ce5

Add deps for native image

ee49cb2

Fix module path for small jdk

77beb2d

Exclude gax-grpc NI config file

61195c0

svm must not be included in the class-path.

612cda1

Otherwise engine-runner NI build fails.

java.prefs module is added in small jdk for NI.

e9d2d4d

Otherwise, NI build fails with "Substitution target for com.oracle.svm.core.posix.darwin.Target_java_util_prefs_FileSystemPreferences is not loaded".

jdk.attach module is added in small jdk for NI.

821bef2

Use Graalvm 25.0.0 in all CI workflows

e7270f3

Akirathan added 2 commits September 22, 2025 15:16

Bump Mockito version.

6ac2d05

Which supports Java 25.

Mockito tests are run with -javaagent cmdline option

e63ac6a

Akirathan mentioned this pull request Sep 22, 2025

Bump Google java format version to 1.28.0 #14038

Merged

5 tasks

Fix native lib versions in native_libs.json golden test file

15b518f

Akirathan added 4 commits September 23, 2025 16:41

Update expected error message when parsing foreign python method

68294bc

Merge branch 'develop' into wip/akirathan/13918-update-graal-25

27f791d

Verify licenses

9377972

Update Bazel GraalVM toolchain to version 25

a1e76be

Akirathan marked this pull request as ready for review September 23, 2025 17:07

Akirathan requested review from hubertp and jdunkerley as code owners September 23, 2025 17:07

hubertp requested changes Oct 27, 2025

View reviewed changes

mergify bot added 2 commits October 27, 2025 14:45

Merge branch 'develop' into wip/akirathan/13918-update-graal-25

0360153

Merge branch 'develop' into wip/akirathan/13918-update-graal-25

3278952

JaroslavTulach added 2 commits October 28, 2025 07:49

Hide enso.* files in distribution/bin directory

2d4d19e

Instructions how to regenerated enso.lib and enso.exp files

0e2e247

JaroslavTulach requested review from JaroslavTulach, hubertp and vitvakatu October 28, 2025 06:56

JaroslavTulach approved these changes Oct 28, 2025

View reviewed changes

vitvakatu approved these changes Oct 28, 2025

View reviewed changes

Merge branch 'develop' into wip/akirathan/13918-update-graal-25

1461983

JaroslavTulach removed the CI: Keep up to date Automatically update this PR to the latest develop. label Oct 28, 2025

jdunkerley approved these changes Oct 28, 2025

View reviewed changes

hubertp approved these changes Oct 28, 2025

View reviewed changes

engine/runner/src/main/java/org/enso/runner/EnsoLibraryFeature.java Show resolved Hide resolved

project/GraalVM.scala Outdated Show resolved Hide resolved

JaroslavTulach added 2 commits October 28, 2025 12:08

Backing 5254099 out

db2e696

Removing other differences against develop branch

8b41e69

JaroslavTulach reviewed Oct 28, 2025

View reviewed changes

distribution/bin/enso.lib

Copy link

Member

JaroslavTulach Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also generated from enso.def

https://github.com/enso-org/enso/pull/14019/files#r2461574134

JaroslavTulach reviewed Oct 28, 2025

View reviewed changes

Use canonical path to temporary folder

8031779

JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Oct 29, 2025

JaroslavTulach mentioned this pull request Oct 29, 2025

Verify EnsoContext can be GCed after cleaning up ContextUtils rule #14219

Open

2 tasks

JaroslavTulach added the CI: Keep up to date Automatically update this PR to the latest develop. label Oct 29, 2025

Merge branch 'develop' into wip/akirathan/13918-update-graal-25

dfc5207

mergify bot merged commit 8c14901 into develop Oct 29, 2025
85 checks passed

mergify bot deleted the wip/akirathan/13918-update-graal-25 branch October 29, 2025 12:43

Update to GraalVM 25 #14019

Update to GraalVM 25 #14019

Uh oh!

Conversation

Akirathan commented Sep 17, 2025 • edited by JaroslavTulach Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Important Notes

Checklist

Uh oh!

Akirathan commented Sep 22, 2025

Uh oh!

Akirathan commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hubertp left a comment

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Akirathan commented Sep 17, 2025 •

edited by JaroslavTulach

Loading

Akirathan commented Sep 22, 2025 •

edited

Loading

JaroslavTulach commented Oct 28, 2025 •

edited

Loading

JaroslavTulach left a comment •

edited

Loading

JaroslavTulach Oct 28, 2025 •

edited

Loading

JaroslavTulach commented Oct 28, 2025 •

edited

Loading

JaroslavTulach commented Oct 29, 2025 •

edited

Loading

JaroslavTulach commented Oct 29, 2025 •

edited

Loading