Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a scaffold setup that runs tests with secure bundle #1505

Draft
wants to merge 6 commits into
base: secure-bundler-hybrid
Choose a base branch
from

Conversation

naugtur
Copy link
Member

@naugtur naugtur commented Mar 2, 2023

  • instrumenting Compartment for bundle doesn't seem possible
  • bundles don't support exit modules. how would we add that?
    • one option is to remove the necessity for the original module to load and run attenuation, but that's something I was striving to avoid - only attenuate what exists.
    • another option is to add the exitModuleImportHook and persist the implementation in the archive/bundle
  • the policy test that attempts some trickery with the browser field is failing with makeModuleFunctor is not a function
  • the test that throws from the attenuator doesn't propagate the error and it goes off as an unhandled rejection. Something about error handling and/or aggregation is different in the bundle runtime.
    • I fixed that by awaiting pendingJobs from link. Now I'm getting another JSON parse error, probably resulting from usage of the fake read function I missed.

},
'fakeLocation',
{
modules: Object.fromEntries(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does specifying the modules here do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing yet. It doesn't work, so I hacked them away in the fixture. I have a feeling I can fix it

@kumavis kumavis force-pushed the secure-bundler-hybrid branch from 4359b9b to a261746 Compare May 2, 2023 21:59
@kumavis kumavis force-pushed the secure-bundler-hybrid branch 2 times, most recently from f08ae39 to 8b17f6b Compare May 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants