Fix ring security vulnerability by upgrading jsonwebtoken to v10#54
Open
rubenhensen wants to merge 1 commit intomainfrom
Open
Fix ring security vulnerability by upgrading jsonwebtoken to v10#54rubenhensen wants to merge 1 commit intomainfrom
rubenhensen wants to merge 1 commit intomainfrom
Conversation
Dependabot detected security vulnerabilities in the ring crate (versions < 0.17.13). The ring dependency was pulled in by jsonwebtoken v8.x, which could not be updated to a secure version without breaking changes. Solution: Upgrade jsonwebtoken from v8 to v10 with the rust_crypto backend, which uses pure Rust cryptographic libraries instead of ring. Changes: - Updated jsonwebtoken from 8.0 to 10 with rust_crypto backend - Removed ring v0.16.20 from the dependency tree entirely - Now using pure Rust crypto libraries (ed25519-dalek, p256, p384, rsa, etc.) - All tests pass and the code compiles successfully This resolves the security advisory for ring affecting versions < 0.17.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ringcrate (CVE affecting versions < 0.17.13)jsonwebtokenfrom v8 to v10 with pure Rust cryptography backendringfrom the dependency treeChanges
jsonwebtokenfrom 8.0 → 10.0 withrust_cryptofeatureringv0.16.20 dependency entirelyed25519-dalekfor Ed25519 signaturesp256andp384for elliptic curve cryptographyrsafor RSA operationshmacandsha2for hashingTest Plan
ringis completely removed from dependency treeSecurity Impact
This PR resolves Dependabot security alerts for the
ringcrate. Therust_cryptobackend provides equivalent cryptographic functionality using pure Rust implementations.Closes the Dependabot security alert for
ring< 0.17.13