Split Safari WASM test into separate job#53
Merged
rubenhensen merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
The matrix-based continue-on-error wasn't working correctly. Now using two separate jobs: - test-wasm-browsers: Chrome & Firefox (required) - test-wasm-safari: Safari only (non-blocking) This ensures Safari failures don't block PRs while Chrome/Firefox tests remain required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for Safari WASM test continue-on-error not working with matrix strategy.
Changes
Split WASM browser tests into two separate jobs:
continue-on-error: true)Context
In PR #51, we tried to make Safari non-blocking using:
This approach didn't work correctly. By splitting Safari into its own job, the
continue-on-error: truesetting now properly prevents Safari test failures from blocking PRs.Related