Skip to content

chore: make function comment match function name #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

chore: make function comment match function name #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion v2/codegen/apigen/endpointgen/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (d *requestDesc) reqDataPathParamExpr(i int) *Statement {
return d.reqDataExpr().Dot(d.pathParamFieldName(i))
}

// reqDataPathParamName returns the field name for the i'th path parameter
// pathParamFieldName returns the field name for the i'th path parameter
// in the reqData struct.
func (d *requestDesc) pathParamFieldName(i int) string {
return fmt.Sprintf("P%d", i)
Expand Down
2 changes: 1 addition & 1 deletion v2/codegen/infragen/configgen/configgen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ func (cb *configUnmarshalersBuilder) typeParamUnmarshalerName(param schema.DeclT
return fmt.Sprintf("_%s_unmarshaler", param.Name)
}

// generateConcreteUnmarshaler generates a function that unmarshals a concrete type, taking into account any
// generateConcreteUnmarshalers generates a function that unmarshals a concrete type, taking into account any
// type arguments passed to the given type
func (cb *configUnmarshalersBuilder) generateConcreteUnmarshalers(typ schema.Type) {
funcBody, _ := cb.typeUnmarshalerFunc(typ)
Expand Down
2 changes: 1 addition & 1 deletion v2/v2builder/v2builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ func (i BuilderImpl) generateTestSpec(ctx context.Context, p builder.TestSpecPar
})
}

// testEnvVars takes a list of env vars and filters them down to the ones
// testEnvVarsToEmbed takes a list of env vars and filters them down to the ones
// that should be embedded within the test binary.
func (i BuilderImpl) testEnvVarsToEmbed(args, envs []string) map[string]string {
if !slices.Contains(args, "-c") {
Expand Down