fix: set default elapsed on MockTransport responses #3719
Closed
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #3712 by setting a default
elapsedvalue oftimedelta(0)on responses returned fromMockTransport.Problem
When creating a
Responsewith pre-loaded content (e.g.,json=...,content=...,text=...), the content is immediately read into_contentin the Response's__init__. Later, when the client wraps the response stream withBoundSyncStream/BoundAsyncStreamto track elapsed time, the stream is never actually consumed because_contentis already set.This causes a
RuntimeErrorwhen accessingresponse.elapsed:Solution
Set
elapsed = timedelta(0)as a default inMockTransport.handle_request()andhandle_async_request()if the response doesn't already have_elapsedset.This:
response.elapsedwithout errorsChanges
import datetimetohttpx/_transports/mock.pyhandle_request()(sync)handle_async_request()(async)Testing
Verified that:
response.elapsedreturnstimedelta(0)for pre-loaded responses