Add response save method #3685
Closed
Add response save method #3685
+172
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation to is_ipv4_hostname and is_ipv6_hostname functions to clarify their purpose and CIDR notation support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Introduced a new helper function, is_ip_address, to check if a given hostname is a valid IP address (either IPv4 or IPv6), including support for CIDR notation. This enhances the utility of the IP validation module.
…ling Introduced a new utility function, normalize_header_key, to standardize HTTP header keys for comparison and storage. This function normalizes keys to lowercase by default, with an option to preserve the original case for compatibility with HTTP/1.1. Updated __all__ to include the new function.
Test branch
This commit adds two new convenience methods to the Response class: 1. json_or_text(): Attempts to parse the response as JSON, automatically falling back to text content if JSON parsing fails. This provides a convenient way to handle responses that may be in either format without explicit exception handling. 2. save_to_file(path, mode='auto'): Saves response content to a file with intelligent handling of different content types. Supports multiple modes: - 'auto': Automatically detects format based on Content-Type header - 'binary': Saves raw bytes (images, PDFs, etc.) - 'text': Saves as text with encoding support - 'json': Parses and saves formatted JSON with indentation These methods enhance the Response API by providing commonly needed functionality that previously required manual implementation. The save_to_file method is particularly useful for downloading and storing various types of content from web APIs and servers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist