-
-
Notifications
You must be signed in to change notification settings - Fork 999
fix CVE-2025-43859 #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CVE-2025-43859 #3564
Conversation
h11 accepts some malformed Chunked-Encoding bodies before 0.16.0, httpcore 1.0.9 ensure using at least 0.16.0
|
I'm actually not sure this is correct. I don't think |
|
i have actually upgraded the downstream package to fix immediately, in my opinion, enforcing a version which solves a critical vulnerability is good thing, but i understand your point |
|
Coming here because I also had to fix a CVE on my repo and found this |
|
I don't really agree, you'd have to upgrade httpx for us to enforce the version at which point you might as well have updated the dependency? |
|
@zanieb thanks for replying :) I'm not too sure what are the deptree repercussions if I bump the h11 version while httpx's dependencies require a lower version. In my view, that leads to inconsistencies and messes up with the pip's dependency resolver. Please educate me if I'm not seeing things straight. |
I'm not sure I follow, but httpx itself does not require the lower version — it allows any 1.x version. There shouldn't be repercussions to bumping h11. If some other dependency requires a lower version of h11, and does not allow a newer version, that is indeed a problem and should be fixed in that package. |
|
Ah I see, I see. The problem is within httpx's dependency |
|
Alright, after installing manually declaring |
|
As @zanieb said, there's no need for HTTPX to actually enforce this. It would only be a problem if httpx didn't allow you to install the safe h11 version. |
|
If it is enforced, the ecosystem would gain awareness of the vulnerability. Not enforcing is going along with the problem. |
|
@danielfcollier adding a lower bound to a new version of httpx does not "increase awareness" of a vulnerability, it just forces an upgrade of the package when upgrading httpx. In either case, you need to be performing upgrades to resolve the vulnerability. You should be using dedicated tooling, e.g., Dependabot, for awareness of CVEs. |
|
It is just a fact that enforcing a higher version would raise the bar, enforce security, and raise awareness - some people are just not educated about vulnerabilities or do not have a security department to take care of these scans. But, ok, when someone reverse engineers the ecosystem to find projects with top vulnerabilities, someone might consider enforcing some updates to strategic dependencies. |
h11 accepts some malformed Chunked-Encoding bodies before 0.16.0, httpcore 1.0.9 ensure using at least 0.16.0
Summary
Checklist