Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test Python 3.13 and 3.14.0-alpha - 3.14 #1001

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JohnVillalovos
Copy link

Also stop testing Python 3.8 as it is End-of-Life as of 2024-10-07. https://devguide.python.org/versions/

Also stop testing Python 3.8 as it is End-of-Life as of 2024-10-07.
https://devguide.python.org/versions/
@tomchristie
Copy link
Member

Okay, shall we see about getting these passing?
The behaviour change is identified in #995

One resolution here would be to change this line...

for __name in __all__:

To add an exclusion for SOCKET_OPTION.

@JohnVillalovos
Copy link
Author

Okay, shall we see about getting these passing? The behaviour change is identified in #995

One resolution here would be to change this line...

for __name in __all__:

To add an exclusion for SOCKET_OPTION.

First will likely need #999 or something similar merged to get the other parts of the CI to pass.

@@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14.0-alpha - 3.14"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify this (allow-prereleases: true is set below):

Suggested change
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14.0-alpha - 3.14"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]

@hugovk
Copy link
Contributor

hugovk commented Apr 1, 2025

The next failure in the yak stack can be fixed by setting the PYO3_USE_ABI3_FORWARD_COMPATIBILITY: 1 env var to allow PYO3 to run on Python 3.14 pre-releases, for example:

(FORCE_COLOR: 1 is optional and adds colour to the CI output, which makes errors easier to find in long logs.)

Then the next failure is because it's trying to build Pillow (a dependency of a dependency) from source because doesn't have wheels yet for 3.14, and most likely they'll be available in the 1st July release (the first one after beta):

The headers or library files could not be found for jpeg,
a required dependency when compiling Pillow from source.

This can be worked around by temporarily installing libjpeg8-dev, something like this (it could be restricted to just the 3.14 build):

Pillow then builds:

And that gets us to the typing.Union failure from:

@tomchristie
Copy link
Member

tomchristie commented Apr 1, 2025

@hugovk Rather than resolve those weirdly specific alpha buglettes, I'd suggest we drop the "benchmarking requirements" as suggested in #964. They're breaking our builds.

(Let's de-yak the stack, please & thanks)

@hugovk
Copy link
Contributor

hugovk commented Apr 5, 2025

Good idea, there's an approved PR for that issue awaiting merge: #965.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants