Fix max_keepalive_connections #1000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazewicz
commented
Mar 26, 2025
| async with pool.stream("GET", "http://example.com/") as response: | ||
| async with pool.stream("GET", "http://example.com/") as response_1, pool.stream( | ||
| "GET", "http://example.com/" | ||
| ) as response_2: | ||
| info = [repr(c) for c in pool.connections] | ||
| assert info == [ | ||
| "<AsyncHTTPConnection ['https://example.com:443', HTTP/1.1, IDLE, Request Count: 2]>", |
There was a problem hiding this comment.
This connection is dropped without the fix.
blazewicz
commented
Mar 26, 2025
| with pool.stream("GET", "http://example.com/") as response: | ||
| with pool.stream("GET", "http://example.com/") as response_1, pool.stream( | ||
| "GET", "http://example.com/" | ||
| ) as response_2: | ||
| info = [repr(c) for c in pool.connections] | ||
| assert info == [ | ||
| "<HTTPConnection ['https://example.com:443', HTTP/1.1, IDLE, Request Count: 2]>", |
There was a problem hiding this comment.
This connection is dropped without the fix.
blazewicz
force-pushed
the
blazewicz/fix-max-keepalive-connections
branch
from
d147c94 to
0aa2ee1
Compare
This commit fixes a bug in both sync and async connection pools where idle connections were dropped from the pool even when max_keepalive_connections limit has not been reached. This happened because the check compared this number to the total number of connections, not only the idle ones.
blazewicz
force-pushed
the
blazewicz/fix-max-keepalive-connections
branch
from
0aa2ee1 to
6414fd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes a bug in both sync and async connection pools where idle connections were dropped from the pool even when max_keepalive_connections limit has not been reached. This happened because the check compared this setting's value to the total number of connections, not only of the idle ones.
Checklist