Skip to content

Conversation

sjro
Copy link
Contributor

@sjro sjro commented Oct 27, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

@extends tag link is broken.

Resolution

In gatsby-transformer-documentation plugin source code (https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-documentationjs/src/gatsby-node.js), only the string that comes after dot is explicitly stored as name.
So, change the jsdoc format for @extends

ex)
@extends sandstone/ActionGuide.ActionGuideBase
=> @extends sandstone/ActionGuide#ActionGuideBase

Additional Considerations

Links

WRO- 12868, WRO-12876

Comments

Enact-DCO-1.0-Signed-off-by: SJ RO ([email protected])

@sjro sjro changed the base branch from master to develop October 27, 2022 02:10
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 70.88% // Head: 70.88% // No change to project coverage 👍

Coverage data is based on head (834f2e3) compared to base (88091d0).
Patch has no changes to coverable lines.

❗ Current head 834f2e3 differs from pull request most recent head 2c22edf. Consider uploading reports for the commit 2c22edf to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1351   +/-   ##
========================================
  Coverage    70.88%   70.88%           
========================================
  Files          137      137           
  Lines         6673     6673           
  Branches      1966     1966           
========================================
  Hits          4730     4730           
  Misses        1447     1447           
  Partials       496      496           
Impacted Files Coverage Δ
ActionGuide/ActionGuide.js 100.00% <ø> (ø)
Alert/Alert.js 100.00% <ø> (ø)
BodyText/BodyText.js 100.00% <ø> (ø)
Button/Button.js 100.00% <ø> (ø)
Checkbox/Checkbox.js 100.00% <ø> (ø)
CheckboxItem/CheckboxItem.js 100.00% <ø> (ø)
DatePicker/DatePicker.js 100.00% <ø> (ø)
DayPicker/DayPicker.js 100.00% <ø> (ø)
Dropdown/Dropdown.js 93.75% <ø> (ø)
FixedPopupPanels/FixedPopupPanels.js 100.00% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant