Skip to content

Conversation

teckliew
Copy link
Member

@teckliew teckliew commented Jan 21, 2020

Right now we have a "Back to Samples" button that is hidden, transparent, and hard to read:
yikes

Use IconButton instead and have it shown at all times in the corner where the closex in Panels is so that it isn't hard to find.
backiconbutton

@Djspaceg
Copy link
Member

Well that looks really nice!

Comment on lines 7 to 8
background-color: black;
color: #ccc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really important to specify the colors here? Could we instead use one of the built-in features of the button to get a similar compatible effect?
I mention because I fear that we have or will have a skin or skinVariant changing sample, which would make this direct assignment look out of place, in addition to the next Theme library using a specific tone of gray for the background rather than black.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in MoonstoneDecorator to take care of styling. Also cleaned up the styles a little bit.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Teck Liew seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants