Only use Fetch API in browser #5596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Sep 19, 2017
| // if we don't have the binary yet, and have the Fetch api, use that | ||
| if (!Module['wasmBinary'] && typeof fetch === 'function') { | ||
| // if we don't have the binary yet, and have the Fetch api, use that, but only when in browser environment | ||
| if (!Module['wasmBinary'] && (ENVIRONMENT_IS_WEB || ENVIRONMENT_IS_WORKER) && typeof fetch === 'function') { |
There was a problem hiding this comment.
overall this looks reasonable to me, thanks. please just add to the comment something like in some other environments, like Electron, fetch may exist but behave differently than on the Web, so avoid it.
There was a problem hiding this comment.
Rephrased, is it better now?
…r process, but is not useful outside browser environment
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch()can be present in some environments like Electron's renderer process, but is not useful outside browser environmentThis is an alternative, simpler approach to #5577