Repository navigation
Pass --no-test-only-unsafe to v8 in testing. NFC - #27943
Merged
Merged
Conversation
sbc100
marked this pull request as ready for review
October 9, 2026 22:10
A recent v8 change means the jsvu wrapper for v8 no generates a warning on startup due to its use of --snapshot_blob argument.
sbc100
force-pushed
the
suppress_v8_warning
branch
from
October 9, 2026 22:24
e196118 to
116b7ff
Compare
Collaborator
Author
|
I might land this change TBR since its currently breaking all our CI runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent v8 change means the jsvu wrapper for v8 now generates a warning on startup due to its use of --snapshot_blob argument.
See https://chromium-review.googlesource.com/c/v8/v8/+/8529769
See GoogleChromeLabs/jsvu#178