Repository navigation
Remove stale asm.js and fastcomp references and dead tests. NFC - #27935
Merged
Merged
Conversation
sbc100
changed the title
sbc100
marked this pull request as ready for review
October 9, 2026 05:46
sbc100
force-pushed
the
remove-asmjs-remnants
branch
2 times, most recently
from
October 9, 2026 06:01
7a4d2af to
e6bb6d5
Compare
sbc100
force-pushed
the
remove-asmjs-remnants
branch
from
October 9, 2026 06:30
e6bb6d5 to
fa8c54b
Compare
sbc100
added a commit
that referenced
this pull request
Oct 9, 2026
Remove orphaned test source, output, and codesize expectation files under `test/` that are no longer referenced by any tests. Split out from #27935
sbc100
force-pushed
the
remove-asmjs-remnants
branch
from
October 9, 2026 16:50
fa8c54b to
1be0298
Compare
dschuff
approved these changes
Oct 9, 2026
Collaborator
Author
|
@kripken maybe you want to chime on this one, since there are some wording changes, not just pure deletion. |
sbc100
changed the title
Remove leftover `asm.js` and `fastcomp` references and tests that are no longer used: - Remove `test/invoke_i.cpp`, two `fastcomp` `invoke_*` tests, and the disabled `test_global_inits` test in `test/test_other.py` that have been skipped since the `fastcomp` era. - Remove `test_preallocated_heap` (`test/browser/test_preallocated_heap*`) and `Module.buffer` documentation in `module.rst` and `Deploying-Pages.rst`, which tested and documented the `asm.js`-only `Module.buffer` feature (`Module.buffer` is not used by Wasm or `wasm2js`). - Remove stale `asm.js`, `.mem`, and `fastcomp` references in `SINGLE_FILE`, `--closure`, and `--emit-symbol-map` documentation and comments across `tools/` and `test/`.
sbc100
force-pushed
the
remove-asmjs-remnants
branch
from
October 9, 2026 23:02
1be0298 to
50c0b61
Compare
kripken
reviewed
Oct 9, 2026
| # Preallocating the buffer in this was is asm.js only (wasm needs a Memory). | ||
| @requires_wasm2js | ||
| def test_preallocated_heap(self): | ||
| self.btest_exit('test_preallocated_heap.c', cflags=['-sWASM=0', '-sIMPORTED_MEMORY', '-sINITIAL_MEMORY=16MB', '-sABORTING_MALLOC=0', '--shell-file', test_file('browser/test_preallocated_heap_shell.html')]) |
Collaborator
Author
There was a problem hiding this comment.
Pre-allocating the buffer via Module.buffer is an asm.js thing. It never worked with Wasm and I don't think it ever worked with wasm2js either.
The test erronously passes, even though Module.buffer is completely ignored (and always has been since asm.js days)
sbc100
enabled auto-merge (squash)
October 9, 2026 23:24
kripken
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove leftover
asm.jsandfastcompreferences and tests that are nolonger used:
test/invoke_i.cpp, twofastcompinvoke_*tests, and thedisabled
test_global_initstest intest/test_other.pythat havebeen skipped since the
fastcompera.test_preallocated_heap(test/browser/test_preallocated_heap*)and
Module.bufferdocumentation inmodule.rstandDeploying-Pages.rst, which tested and documented theasm.js-onlyModule.bufferfeature (Module.bufferis not used by Wasm orwasm2js).asm.js,.mem, andfastcompreferences inSINGLE_FILE,--closure, and--emit-symbol-mapdocumentation andcomments across
tools/andtest/.