Fix missing closing parentheses under GL_DEBUG - #27517
Merged
Merged
Conversation
Collaborator
Author
|
Context: #27503 (comment). |
Collaborator
|
Is there a test that we can add |
Collaborator
Author
|
Added a regression test in commit b1e1b9b that previously failed with: Details$ ./test/runner browser.test_webgl_preprocessor_variables*
Running 4 tests
Using 2 parallel test processes
...
======================================================================
FAIL: test_webgl_preprocessor_variables_webgl2_extensions (test_browser.browser.test_webgl_preprocessor_variables_webgl2_extensions)
----------------------------------------------------------------------
...
Stdout:
error: /home/kleisauke/emscripten/src/lib/libwebgl.js: failure to execute JS library "/home/kleisauke/emscripten/src/lib/libwebgl.js":
error: /home/kleisauke/emscripten/src/lib/libwebgl.js: use -sVERBOSE to save preprocessed JS
Internal compiler error JS compiler
Please create a bug report at https://github.com/emscripten-core/emscripten/issues/
with a log of the build and the input files used to run. Exception message: "/home/kleisauke/emscripten/src/lib/libwebgl.preprocessed.js:1787
dbg(`Shader source after preprocessing: ${source}`;
^^
SyntaxError: missing ) after argument list
...
======================================================================
FAIL: test_webgl_preprocessor_variables_webgl1_extensions (test_browser.browser.test_webgl_preprocessor_variables_webgl1_extensions)
----------------------------------------------------------------------
...
Stdout:
error: /home/kleisauke/emscripten/src/lib/libwebgl.js: failure to execute JS library "/home/kleisauke/emscripten/src/lib/libwebgl.js":
error: /home/kleisauke/emscripten/src/lib/libwebgl.js: use -sVERBOSE to save preprocessed JS
Internal compiler error JS compiler
Please create a bug report at https://github.com/emscripten-core/emscripten/issues/
with a log of the build and the input files used to run. Exception message: "/home/kleisauke/emscripten/src/lib/libwebgl.preprocessed.js:1570
dbg(`Shader source after preprocessing: ${source}`;
^^
SyntaxError: missing ) after argument list
...
----------------------------------------------------------------------
Ran 4 tests in 1.916s
FAILED (failures=2)
Total core time: 2.622s. Wallclock time: 1.916s. Parallelization: 1.37x. |
sbc100
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.