Skip to content

[Docs] migrate sphinx theme to shibuya#27035

Open
hwhsu1231 wants to merge 1 commit into
emscripten-core:mainfrom
hwhsu1231-fork:shibuya-theme
Open

[Docs] migrate sphinx theme to shibuya#27035
hwhsu1231 wants to merge 1 commit into
emscripten-core:mainfrom
hwhsu1231-fork:shibuya-theme

Conversation

@hwhsu1231
Copy link
Copy Markdown
Contributor

@hwhsu1231 hwhsu1231 commented May 30, 2026 •
edited
Loading

  • Remove emscripten_sphinx_rtd_theme
  • Pin sphinx==7.4.7, sphinx-design==0.6.1, shibuya==2026.5.19
  • Refactor home page with sphinx-design
  • Internationalize strings in conf.py file

@hwhsu1231 hwhsu1231 mentioned this pull request May 30, 2026
Open
@hwhsu1231 hwhsu1231 force-pushed the shibuya-theme branch 3 times, most recently from e704197 to a6a85a4 Compare May 30, 2026 09:45
sbc100
sbc100 reviewed May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for working on this.

I wonder if we can get a preview of what this looks like so we can take a look before landing this.

Comment thread .gitignore Outdated
@hwhsu1231
Copy link
Copy Markdown
Contributor Author

hwhsu1231 commented May 31, 2026

I wonder if we can get a preview of what this looks like so we can take a look before landing this.

I believe this Pull request previews is what you're looking for.

@hwhsu1231
[Docs] migrate sphinx theme to shibuya
43147cf 
- Remove `emscripten_sphinx_rtd_theme`
- Pin `sphinx==7.4.7`, `sphinx-design==0.6.1`, `shibuya==2026.5.19`
- Refactor home page with `sphinx-design`
- Internationalize strings in `conf.py` file
@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented May 31, 2026

I wonder if we can get a preview of what this looks like so we can take a look before landing this.

I believe this Pull request previews is what you're looking for.

Is that easy to setup? IIUC we don't currently use readthedocs.com at all today.

@hwhsu1231
Copy link
Copy Markdown
Contributor Author

hwhsu1231 commented May 31, 2026

Not sure because I haven't tried it yet.

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented May 31, 2026

I can try downloading this patch and take a look locally.

@hwhsu1231
Copy link
Copy Markdown
Contributor Author

hwhsu1231 commented May 31, 2026

I wonder why these two checks failed after I removed the changes on .gitignore:

Screenshot_20260531_114331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hwhsu1231 @sbc100