Skip to content

Update mimalloc to 2.2.4 #24542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update mimalloc to 2.2.4 #24542

wants to merge 3 commits into from

Conversation

kleisauke
Copy link
Collaborator

No description provided.

@kleisauke kleisauke mentioned this pull request Jun 10, 2025
Draft
@kleisauke
Copy link
Collaborator Author

This got me thinking, perhaps we should migrate this to a submodule? I'm not sure it's feasible for the system/ directory though, since it would complicate cloning (you'd need to use --recurse-submodules). I'm also not sure if emsdk already handles that.

@sbc100
Copy link
Collaborator

sbc100 commented Jun 10, 2025

This got me thinking, perhaps we should migrate this to a submodule? I'm not sure it's feasible for the system/ directory though, since it would complicate cloning (you'd need to use --recurse-submodules). I'm also not sure if emsdk already handles that.

Emscripten already uses a couple of submodules (today they are only for developers / testing) but it should be fine to start using them more.

However, we already include copies of musl / libc++ / compiler-rt and libc++abi, so converting this tiny library to a submodule would not make much difference to amount of verbatim copying we have.

sbc100
sbc100 reviewed Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the tests pass.

Is this the latest official release?

@kleisauke
Copy link
Collaborator Author

Is this the latest official release?

Yes, this is the latest stable (non-beta) release. See e.g. https://github.com/microsoft/mimalloc/tags (v3.1.4 is still in beta).

kleisauke
kleisauke commented Jun 10, 2025
View reviewed changes
system/lib/mimalloc/src/prim/emscripten/prim.c
@@ -196,7 +201,7 @@ bool _mi_prim_random_buf(void* buf, size_t buf_len) {
// Thread init/done
//----------------------------------------------------------------

#ifdef __EMSCRIPTEN_SHARED_MEMORY__
#if defined(MI_USE_PTHREADS)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was changed in microsoft/mimalloc@0b3cd51#diff-ceeeab7fe916469cce6ab04ba551f6a2411d093f5cb3374cf95f0a1f9bd674aaR203 and microsoft/mimalloc@8f87455#diff-dc7c5d6afe67633e8647bc21fb12adebb183b49dd43e6bd47e1b7a822587fbe0R17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleisauke @sbc100