Repository navigation
Add support for getentropy in d8 - #24185
Conversation
4a73c46 to
b7f2c75
Compare
sbc100
left a comment
There was a problem hiding this comment.
lgtm, are you using d8 in production somewhere? i.e. what is the motivation for this change?
|
I asked @erikcorry if he could look into ways to improve codegen for Python ceval.c and he said it would be much easier if he could run Pyodide in d8 as opposed to having to build node or such against a branch of v8. |
|
But it was surprisingly not too hard to get it to work: https://github.com/pyodide/pyodide/pull/5607/files |
So you are patching / working on v8? Indeed that does sounds like a good use case. If you just want recent builds of v8 in node you can also use node canary which I think its basically a nightly build: https://nodejs.org/download/v8-canary/ |
sbc100
left a comment
There was a problem hiding this comment.
Looks like you need to add os.system to src/closure-externs/node-externs.js maybe?
|
The same set of tests failed twice in CI but they pass for me locally. |
|
The closure compilr failure looks real: |
|
Hmm: |
Use
os.systemto read from/dev/urandomand then base 64 encode the result. Then usebase64Decodeto read the result. Only works when--enable-os-systemis passed to d8.