Fix progress reporting for compressed downloads in fetchRemotePackage #24144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Apr 18, 2025
tools/file_packager.py
Outdated
| if (isCompressed) { | ||
| // Estimate progress proportionally, assuming 3:1 compression ration | ||
| loaded = Math.min(total, | ||
| total * (decompressedLoaded / (packageSize || total * 3))); |
There was a problem hiding this comment.
This seems a little too much like guesswork. Is there really no better way?
vjyanand
force-pushed
the
fix-download-progress-compression
branch
2 times, most recently
from
8d30366 to
0a9dfbf
Compare
sbc100
reviewed
Apr 21, 2025
vjyanand
force-pushed
the
fix-download-progress-compression
branch
from
0a9dfbf to
290785d
Compare
|
Can you update the PR description and title now that we have changed the PR content? |
vjyanand
changed the title
sbc100
changed the title
|
Do you know why we cannot just use |
just my guess, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server uses compression (e.g., Brotli (
br) or Gzip (gzip)), theContent-Lengthheader in the HTTP response represents the compressed size of the data, not the uncompressed size. ThefetchRemotePackagefunction, however, tracks the uncompressed size of the downloaded data (via value.length of each chunk after decompression). This leads to a discrepancy where the reportedtotalLoaded(uncompressed) exceeds the Content-Length (compressed), causing inaccurate progress reporting.The Fetch API does not provide direct access to the compressed stream’s size for each chunk, as decompression is handled transparently. The updated code addresses this by aligning the total and loaded values with the compressed size from Content-Length when the content is compressed. Specifically:
This ensures progress reporting reflects the compressed size, preventing totalLoaded from exceeding total.