Fix for core_2gb.test_fs_js_api_wasmfs. NFC #23885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests is failing on the emscripten-releases waterfall. In 2Gb+ mode its no longer possible to fix the returning of pointers with the returning of `-errno` since negative number are valid pointers in this mode.
sbc100
commented
Mar 11, 2025
| var bufPtr = stackAlloc({{{ POINTER_SIZE }}}); | ||
| FS.handleError(__wasmfs_readlink(stringToUTF8OnStack(path), bufPtr)); | ||
| var readBuffer = {{{ makeGetValue('bufPtr', '0', '*') }}}; | ||
| return UTF8ToString(readBuffer); |
There was a problem hiding this comment.
I guess this is where a new multi-value ABI could be useful! See WebAssembly/tool-conventions#247
kripken
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests is failing on the emscripten-releases waterfall.
In 2Gb+ mode its no longer possible to fix the returning of pointers with the returning of
-errnosince negative number are valid pointers in this mode.