Repository navigation
Conversation
Member
|
I see we have Is that not enough to show the problem this PR fixes? (If not, can we add to that test, or add a new one?) |
Contributor
Author
|
I'm guessing nothing in that test calls |
Collaborator
|
Seems like someone else was experiencing this in #27932. I'll see if I can revive this PR |
Collaborator
Contributor
Author
|
You can take over, sorry for not following up here!On Oct 8, 2026, at 22:20, Sam Clegg ***@***.***> wrote:sbc100 left a comment (emscripten-core/emscripten#22304)
I created #27934, unless @m4burns you want to update this one instead?
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
|
Closing in favor of #27934 |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 9, 2026
Supersedes emscripten-core#22304. Instead of linking an executable with `--oformat=wasm` or `--oformat=bare`, set `CMAKE_TRY_COMPILE_TARGET_TYPE` to `STATIC_LIBRARY` so `try_compile` only compiles and archives the object file without running the linker. Pass `-fno-lto` so that even when `-flto` is present in `CFLAGS`, a standard Wasm object file (containing the plain ASCII `INFO:size[...]` string) is emitted rather than LLVM bitcode. Also add `-sWASM_WORKERS`, `-sEXIT_RUNTIME`, and `-flto` coverage to `test_cmake_check_type_size`. Fixes: emscripten-core#27932
sbc100
added a commit
that referenced
this pull request
Oct 9, 2026
Supersedes #22304. Instead of linking an executable with `--oformat=wasm` or `--oformat=bare`, set `CMAKE_TRY_COMPILE_TARGET_TYPE` to `STATIC_LIBRARY` so `try_compile` only compiles and archives the object file without running the linker. Pass `-fno-lto` so that even when `-flto` is present in `CFLAGS`, a standard Wasm object file (containing the plain ASCII `INFO:size[...]` string) is emitted rather than LLVM bitcode. Also add `-sWASM_WORKERS`, `-sEXIT_RUNTIME`, and `-flto` coverage to `test_cmake_check_type_size`. Fixes: #27932 --------- Co-authored-by: Marc Burns <m4burns@uwaterloo.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes emscripten's patched
CheckTypeSizeCMake module to work when compiler flags imply shared memory use.Before this change, trying to configure a CMake project that uses
check_type_sizewhen compiler flags implied shared memory (e.g.-sWASM_WORKERS) caused an error:This PR resolves the issue by changing
oformattobare, which skips the post-link phase. Type size information can still be extracted from the output.