Skip to content

Improve/cleanup browser test reporting #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve/cleanup browser test reporting #14835

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 10, 2021

  • Use a single onerror handler handler.
  • Report exceptions as test results

@sbc100 sbc100 force-pushed the cleanup_browser_reporting branch 3 times, most recently from 2a800a8 to b93af1a Compare August 13, 2021 19:34
@sbc100 sbc100 force-pushed the cleanup_browser_reporting branch from b93af1a to ed3f528 Compare August 17, 2021 23:31
@sbc100 sbc100 requested a review from kripken August 18, 2021 17:36
@sbc100 sbc100 force-pushed the cleanup_browser_reporting branch 6 times, most recently from 80e9c83 to 806ac87 Compare August 19, 2021 03:51
kripken
kripken reviewed Aug 19, 2021
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sbc100 sbc100 force-pushed the cleanup_browser_reporting branch 3 times, most recently from b08de67 to 0ab97a0 Compare August 25, 2021 22:27
@sbc100 sbc100 force-pushed the cleanup_browser_reporting branch from 0ab97a0 to 2a24b91 Compare September 14, 2021 17:19
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken