Skip to content

fix issue #71 (Exception when pointing multiple PdfFileSpecification to a single PdfEmbeddedFileStream) #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix issue #71 (Exception when pointing multiple PdfFileSpecification to a single PdfEmbeddedFileStream) #292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30e83ee
EXP-14388: temp fix for issue #71 (PdfFileSpecification constructor)
julienrffr Jan 8, 2024
86c2498
Merge branch 'master' into exp-14388-issue-71-temp-fix-filespec-files…
julienrffr Jun 7, 2024
95591a3
Merge branch 'master' into exp-14388-issue-71-temp-fix-filespec-files…
julienrffr Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/foundation/src/PDFsharp/src/PdfSharp/Pdf.Advanced/PdfFileSpecification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// PDFsharp - A .NET library for processing PDF
// PDFsharp - A .NET library for processing PDF
// See the LICENSE file in the solution root for more information.

namespace PdfSharp.Pdf.Advanced
Expand Down Expand Up @@ -28,7 +28,8 @@ void Initialize()

var embeddedFileDictionary = new PdfDictionary(Owner);

Owner.Internals.AddObject(_embeddedFileStream);
if(_embeddedFileStream.Reference is null) // 2 or more PdfFileSpecification could reference the same PdfEmbeddedFileStream, so it may not be necessary to add it again to Internals
Owner.Internals.AddObject(_embeddedFileStream);
embeddedFileDictionary.Elements.SetReference(Keys.F, _embeddedFileStream.Reference ?? throw TH.InvalidOperationException_ReferenceMustNotBeNull());
embeddedFileDictionary.Elements.SetReference(Keys.UF, _embeddedFileStream.Reference);

Expand Down