generated from pitmonticone/LeanProject
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finite models of Isomorphism #83
Draft
mpenciak
wants to merge
21
commits into
emilyriehl:main
Choose a base branch
from
mpenciak:pushouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mpenciak there was a conflict in the imports in CoherentIso that I resolved by importing the union. If you meant to cut something that wasn't necessary, you might have to cut it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR (joint with @nimarasekh) adds a pair of finite models of
CoherentIso
(Model2dCoherentIso
andModel3dCoherentIso
), and a pair of morphisms between them to show they are equivalent (map2dModelto3dModel
andmap3dModeltoCoherentIso
).The two morphisms have sorries in their definitions related to showing some diagrams commute.
There's a lot of cleanup that's likely possible, and the definitions can probably be made better as this was a learning experience for both of us for the simplicial category library.