Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify platform-specific details for Viewport positioning #5715

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

aspiringLich
Copy link
Contributor

@aspiringLich aspiringLich commented Feb 12, 2025

On Wayland (and android apparently) it is not possible for applications to position their windows or request the window position (for some reason). This is not specified in the documentation.

proof: winit::set_outer_position, winit::outer_position, winit::inner_position all specify that Android / Wayland are not supported.

@aspiringLich aspiringLich changed the title Clarify platform-specific details for Viewports Clarify platform-specific details for Viewport positioning Feb 12, 2025
Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link

Preview available at https://egui-pr-preview.github.io/pr/5715-viewport-position-docs
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

Copy link
Collaborator

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, should've realized in the first review, we should mention that this is eframe specific, since it might be different for someone e.g. using bevy_egui. I'll apply the suggestions and merge this now, thanks!

@lucasmerlin lucasmerlin added eframe Relates to epi and eframe docs and examples Improving and adding documentation and examples egui labels Feb 20, 2025
@lucasmerlin lucasmerlin merged commit 27e7303 into emilk:master Feb 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and examples Improving and adding documentation and examples eframe Relates to epi and eframe egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with_position method of ViewportBuilder does not seem to work on wayland
2 participants