Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wayfire to portal UseIn list, as it is also supported #62

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

kode54
Copy link
Contributor

@kode54 kode54 commented Oct 27, 2020

Quick and dirty change. I intend to add some basic setup to the readme as well, if nobody else is doing that. Mainly just a hint to use the systemctl or dbus to systemd environment setup in autostart, or else the auto loaded portal won't actually work.

@danshick
Copy link
Collaborator

No problem extending the UseIn list. Without looking, I think the semicolon syntax is correct.

As for the readme changes, I'm planning on overhauling the docs a bit shortly. Namely adding man pages. I've also been working on a wiki page explaining the quirks of environment variables and systemd/dbus activated services. I'd appreciate your feedback as it is brand new. Let me know if it covers the setup instructions you were planning to add. Once more people have reviewed it, I plan on linking to it from the readme prominently.

Thanks for the PR!

@kode54
Copy link
Contributor Author

kode54 commented Oct 27, 2020

Well, my usage involves a full environment pass, but that's a bit drastic, as it probably just needs one more variable than I was passing before. Possibly the one which identifies the DE in use. These steps are employed by the autostart for Wayfire, using a 0 prefix on the entry name, so they run first.

Arch's sway and AUR sway-git packages also include a /etc/sway/config.d insert to do this automatically, but only for a limited number of variables, and I think I need to file a bug report to get the same variable added to the upstream package's config snippet, so it will work under sway by default.

I'm also going to file feature request for something I may end up implementing myself. E: Never mind, I see #59 and #60 have me covered there.

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thanks!

@emersion emersion merged commit cb36e0d into emersion:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants